Add callback support in settings and tools #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
jamesbraza
reviewed
Oct 15, 2024
jamesbraza
reviewed
Oct 15, 2024
mskarlin
reviewed
Oct 15, 2024
jamesbraza
reviewed
Oct 15, 2024
Change callbacks to be lists of functions rather than just functions Enhance tests
dosubot
bot
added
size:L
mskarlin
reviewed
Oct 16, 2024
dosubot
bot
added
size:M
jamesbraza
reviewed
Oct 16, 2024
Co-authored-by: James Braza <[email protected]>
jamesbraza
reviewed
Oct 16, 2024
dosubot
bot
added
size:L
mskarlin
reviewed
Oct 16, 2024
mskarlin
approved these changes
Oct 16, 2024
jamesbraza
reviewed
Oct 16, 2024
| @pytest.mark.flaky(reruns=3, only_rerun=["AssertionError", "EmptyDocsError"]) | ||
| @pytest.mark.asyncio | ||
| async def test_agent_sharing_state( | ||
| agent_test_settings: Settings, subtests: SubTests | ||
| agent_test_settings: Settings, subtests: SubTests, callback_type: str |
There was a problem hiding this comment.
This should be callback_type: str | None
| gather_evidence_initialized_callback = AsyncMock() | ||
| gather_evidence_completed_callback = AsyncMock() | ||
|
|
||
| callbacks = { |
There was a problem hiding this comment.
Not sure it really matters, but it's more future proof to use callbacks.update here instead of redefining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds callback support to Settings
Tools can invoke these callbacks
I wrote this in a way so that the callbacks are immutable, future flexibility, and direct.
There will likely be more tools using this infrastructure in the future.